• dejected_warp_core@lemmy.world
    link
    fedilink
    arrow-up
    3
    ·
    6 months ago

    Honestly I don’t mind the indentation since C isn’t going to give us many ways to address this with as little code.

    That said, with compilers that are good at inlining trivial functions, I really do appreciate the “it does what it says on the tin” approach to using functions on things like this. Even if they’re only used once. Comments would help too.

    The logic in these if statements is inscrutable on a cold read like this. To me, that’s a maintenance risk; imagine seeing a snippet this size on a PR. Having functions that name what the hell is going on could only help.